refactor: move ChinlanDispatcher.m back to root#39
Merged
Conversation
Chinlan/ held only Dispatcher.m, so the directory added no grouping value. Move the file back to Sources/KiouEngineBridge/ChinlanDispatcher.m (matching its symbol scope) and update the cave_kinds.md path reference. Verified with make jailed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Refactors the chinlan-only dispatcher implementation by relocating it to the Sources/KiouEngineBridge/ root, and updates internal documentation to match the new path. This keeps the chinlan dispatcher easier to discover while removing a single-file subdirectory.
Changes:
- Moved/renamed the chinlan dispatcher implementation to
Sources/KiouEngineBridge/ChinlanDispatcher.m. - Updated
docs/research/cave_kinds.mdto reference the new dispatcher path.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/KiouEngineBridge/ChinlanDispatcher.m | Adds the chinlan-only dispatcher/publish implementation at the module root (same logic, new location). |
| docs/research/cave_kinds.md | Updates the documented dispatcher path to the new filename/location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Chinlan/Dispatcher.m->ChinlanDispatcher.m(back atSources/KiouEngineBridge/root). TheChinlan/directory was holding only one file, so it added no grouping value.Cross-reference in
docs/research/cave_kinds.mdupdated to the new path.Test plan
make jailedbuilds clean locally. CI will cover the other two flavours.🤖 Generated with Claude Code